Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] Simple function extraction for buildMappingForm #14741

Merged
merged 1 commit into from
Jul 5, 2019
Merged

[REF] Simple function extraction for buildMappingForm #14741

merged 1 commit into from
Jul 5, 2019

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Jul 5, 2019

Overview

Simple refactor toward making this function less toxic.

Before

Toxic function unbelievably long.

After

Toxic function slightly less long.

@civibot
Copy link

civibot bot commented Jul 5, 2019

(Standard links)

@civibot civibot bot added the master label Jul 5, 2019
@colemanw
Copy link
Member Author

colemanw commented Jul 5, 2019

@totten I miss our Save the Fish warning.

@eileenmcnaughton
Copy link
Contributor

I re-did the same extraction locally & was able to get the same result - merging

@eileenmcnaughton eileenmcnaughton merged commit f8e09be into civicrm:master Jul 5, 2019
@eileenmcnaughton eileenmcnaughton deleted the mappingExt branch July 5, 2019 20:47
@eileenmcnaughton
Copy link
Contributor

@colemanw I think the fish still shows - it's just attached to the wrong functions now

@colemanw
Copy link
Member Author

colemanw commented Jul 5, 2019

@eileenmcnaughton https://github.com/civicrm/civicrm-core/blob/5.15/.toxic.json#L39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colemanw @eileenmcnaughton